Skip to content

fix(route): don't get stalled by "runBeforeUnload" #38748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Skn0tt merged 4 commits into from
Jan 12, 2026
Merged

fix(route): don't get stalled by "runBeforeUnload" #38748

Skn0tt merged 4 commits into from
Jan 12, 2026

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jan 12, 2026 •
edited
Loading

This condition is stalling routes after page.close(runBeforeUnload: true):

playwright/packages/playwright-core/src/client/page.ts

Lines 197 to 199 in 7c03101

// If the page was closed we stall all requests right away.
if (this._closeWasCalled || this._browserContext._closingStatus !== 'none')
return;

It was added in https://github.com/microsoft/playwright/pull/28414/changes#diff-b2b8e731138f178e6972c51b45f112fc60aff0eec1072e9899b3a5df2cf1133a, and I can't quite spot why. We can also remove that condition entirely.

Closes #38731

@Skn0tt Skn0tt requested a review from dgozman January 12, 2026 13:54
@Skn0tt Skn0tt self-assigned this Jan 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

Test results for "MCP"

1 failed
❌ [chromium] › mcp/core.spec.ts:167 › browser_resize @mcp-macos-15

2821 passed, 116 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

Test results for "tests 1"

8 failed
❌ [default] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [default-reuse] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default-reuse] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [default-trace] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default-trace] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [playwright-test] › expect.spec.ts:508 › should support toHaveURL with baseURL from webServer @macos-latest-node20
❌ [playwright-test] › playwright.spec.ts:877 › page.pause() should disable test timeout @macos-latest-node20

6 flaky ⚠️ [installation tests] › playwright-cli.spec.ts:21 › cli should work `@package-installations-ubuntu-latest`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35 › should update locator highlight `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:379 › should reveal errors in the sourcetab `@macos-latest-node20`

34408 passed, 696 skipped

Merge workflow run.

@Skn0tt Skn0tt merged commit 03a996f into microsoft:main Jan 12, 2026
29 of 32 checks passed
This was referenced Jan 12, 2026
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

@Skn0tt Skn0tt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: page.route() handler leads to stalling/pending fetch requests when dialog is triggered

2 participants

@Skn0tt @dgozman